Skip to content

UPI e2e: remove compute section in generated install-config #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 1 commit into from
Closed

UPI e2e: remove compute section in generated install-config #6713

vrutkovs wants to merge 1 commit into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 15, 2020

This ensures masters are not labelled as workers on UPI AWS runs

UPI e2e: remove compute section in generated install-config
a02a578 
This ensures masters are not labelled as workers on UPI AWS runs
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign tomassedovic
You can assign the PR to them by writing /assign @tomassedovic in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 15, 2020

/retest

@wking
Copy link
Member

wking commented Jan 15, 2020

An alternative to this would be setting mastersSchedulable false, like this.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 16, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2020

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/fcos/e2e-vsphere a02a578 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi a02a578 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy a02a578 link /test pj-rehearse
ci/prow/pj-rehearse a02a578 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title WIP UPI e2e: remove compute section in generated install-config UPI e2e: remove compute section in generated install-config Jan 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 16, 2020

Okay, that worked - masters are no longer labelled as workers. However invoker test still fails (not sure if its related).

An alternative to this would be setting mastersSchedulable false, like this.

I think that would be a bit more confusing - masters would still be labelled as workers with this, but won't be schedulable?

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 16, 2020

/cc @wking @smarterclayton

@wking
Copy link
Member

wking commented Jan 18, 2020

#6741 talks about mastersSchedulable, and should have some rehearsals you can look at.

@jstuever
Copy link
Contributor

jstuever commented Jan 22, 2020

Doesn't removing this from install-config.yaml cause it to just revert to default (with replicas: 3)?

@vrutkovs vrutkovs closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrutkovs @openshift-ci-robot @wking @jstuever